Repository navigation
Conversation
Collaborator
Author
|
@claude review |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Private-table refresh recovery and destructive demo recreation failures remain unresolved.
2 open findings
What changed in this PR
Refreshes ETS table metadata when reloading a snapshot in Voyager.
Changes:
- Reloads metadata and reports refresh failures while retaining prior info.
- Adds regression tests and stable metadata element IDs.
- Expands interactive ETS demo helpers and adds a launcher.
| File | Description |
|---|---|
| test/voyager_web/live/ets_table_live_test.exs | Tests metadata reloads and failure handling. |
| lib/voyager_web/live/ets_table_live.ex | Refreshes metadata during snapshot reloads. |
| lib/voyager_web/components/ets_peek_components.ex | Adds record-count and memory element IDs. |
| dev/mock_nodes/ets.sh | Launches the interactive ETS demo node. |
| dev/ets_demo_node.exs | Adds table mutation and recreation helpers. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Collaborator
Author
|
@claude review |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Late chunk replies can restore cleared records, and metadata-only refreshes lack loading-state handling.
2 open findings
2 resolved since last review
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Collaborator
Author
|
@claude review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.